add optional more optional parameters to personalize more the embed #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipeevski
requested changes
Dec 29, 2020
| public $width = '100%'; | ||
| public $height = '800'; | ||
| public $width; | ||
| public $height; | ||
|
|
||
| /** | ||
| * Default constructor | ||
| * | ||
| * @param $url string base url for the Metabase installation | ||
| * @param $key int secret Metabase key | ||
| */ |
There was a problem hiding this comment.
Need to add the new parameters to the documentation (phpdoc block)
src/Embed.php
Outdated
|
|
||
| /** | ||
| * Default constructor | ||
| * | ||
| * @param $url string base url for the Metabase installation | ||
| * @param $key int secret Metabase key | ||
| */ | ||
| public function __construct($url, $key) | ||
| public function __construct($url, $key, $border = true, $title = false, $width = '100%', $height = '800') |
There was a problem hiding this comment.
Consider ordering the parameters so the most often used ones are first - perhaps: title, width, height, border
Align comments.
ipeevski
approved these changes
Dec 29, 2020
|
Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to change the "default" settings if you want to customize your iframe a bit more.