Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aquamarine crate fails to build since vendorCargoDeps gained overrides #618

Closed
msfjarvis opened this issue May 19, 2024 · 2 comments · Fixed by #619
Closed

aquamarine crate fails to build since vendorCargoDeps gained overrides #618

msfjarvis opened this issue May 19, 2024 · 2 comments · Fixed by #619
Labels
bug Something isn't working

Comments

@msfjarvis
Copy link

msfjarvis commented May 19, 2024

Describe the bug

The aquamarine crate bundles some extra files in a doc/js folder which seem to get filtered out, resulting in a build failure when the Rust tries to include it. This used to work up till 27025ab

Build log: https://gist.github.com/msfjarvis/7b2c6235c592f92a197aa437c7e0b771

Reproduction

This repo reproduces the bug when running nix flake check https://github.com/msfjarvis/linkleaner/tree/779f427c16e0be406b460437cadba9d72ef2d543

@msfjarvis msfjarvis added the bug Something isn't working label May 19, 2024
msfjarvis added a commit to msfjarvis/linkleaner that referenced this issue May 19, 2024
@ipetkov
Copy link
Owner

ipetkov commented May 19, 2024

Thank you for the report and the reproduction @msfjarvis! Should be fixed with #619 😄

@msfjarvis
Copy link
Author

Was able to confirm locally that the PR does fix the issue, thanks for the speedy fixes as always!

jfly added a commit to molybdenumsoftware/pr-tracker that referenced this issue May 20, 2024
The automated bump got unlucky and ran into
ipetkov/crane#618, which has since been fixed.
Just running `nix flake lock` was enough to fix things.

That said, it's good a human got involved, because I noticed a new
warning:

    trace: warning: `crane.lib.${system}` is deprecated. please use `(crane.mkLib nixpkgs.legacyPackages.${system})` instead

I went ahead and fixed that while I was in here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants