Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace toml dependency with toml_edit to preserve comments #407

Merged
merged 8 commits into from
Oct 1, 2023
Merged

Replace toml dependency with toml_edit to preserve comments #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0139e91
replace dependency toml with toml_edit to preserve comments
danjl1100 Sep 30, 2023
40b6a3f
update changelog for PR #407
danjl1100 Sep 30, 2023
b62e884
fixup CHANGELOG addition for #407
danjl1100 Oct 1, 2023
3efef9b
replace exhaustive table match with dyn, add missing comments
danjl1100 Oct 1, 2023
be233e6
clarify TOML source comment
danjl1100 Oct 1, 2023
242a4e4
remove key/value formatting merge and update test string accordingly
danjl1100 Oct 1, 2023
af342cd
Merge remote-tracking branch 'origin/master' into danjl1100/toml_edit
ipetkov Oct 1, 2023
8f0f13e
Slightly reword CHANGELOG
ipetkov Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## Unreleased

### Fixed
* Fixed handling of Cargo workspace inheritance for git-dependencies where said
crate relies on reading non-TOML metadata (i.e. comments) from its Cargo.toml
at build time. ([#407](https://github.com/ipetkov/crane/pull/407))

## [0.14.1] - 2023-09-23

### Fixed
Expand Down
33 changes: 3 additions & 30 deletions pkgs/crane-utils/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkgs/crane-utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ publish = false
anyhow = "1"
serde_json = "1"
serde = { version = "1", features = ["derive"] }
toml = { version = "0.7.3", features = ["preserve_order"] }
toml_edit = "0.20.1"

[dev-dependencies]
pretty_assertions = "1.3.0"