New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handler clearance neglected? #7

Closed

codepushr opened this issue Dec 12, 2016 · 1 comment

Labels

codepushr commented Dec 12, 2016 •

edited

Loading

In the gorilla/session description it states:

Important Note: If you aren't using gorilla/mux, you need to wrap your handlers with context.ClearHandler as or else you will leak memory! An easy way to do this is to wrap the top-level mux when calling http.ListenAndServe:
http.ListenAndServe(":8080", context.ClearHandler(http.DefaultServeMux))

Echo is using an own router so I'm wondering if this middleware is already doing that to avoid memory leaks?

Source> http://www.gorillatoolkit.org/pkg/sessions

ipfans added a commit that referenced this issue


          Fix #7: Avoid memory leak for echo v2

c6634b5

ipfans closed this as completed in

af6b819

ipfans added the kind/bug label

Owner

ipfans commented Mar 9, 2017

This issue is be fixed, thanks for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment