Fix: disable KeepAlives in server

See discussion in ipfs/kubo#5168

We cannot stream responses with keep-alives enabled.

I prefer this to not be a client feature, as otherwise users might end up
shooting themselves in the foot.

Note, the price is a corrupted request body which gets added
normally and gives wrong hashes!

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>

adder/adderutils/adderutils.go

@@ -39,7 +39,11 @@ func AddMultipartHTTPHandler(
 	}
 
 	enc := json.NewEncoder(w)
-	w.Header().Add("Content-Type", "application/octet-stream")
+	// This must be application/json otherwise go-ipfs client
+	// will break.
+	w.Header().Add("Content-Type", "application/json")
+	// Browsers should not cache when streaming content.
+	w.Header().Add("Cache-Control", "no-cache")
 	w.WriteHeader(http.StatusOK)
 
 	var wg sync.WaitGroup

api/rest/restapi.go

@@ -113,7 +113,9 @@ func NewAPIWithHost(cfg *Config, h host.Host) (*API, error) {
 		IdleTimeout:       cfg.IdleTimeout,
 		Handler:           router,
 	}
-	s.SetKeepAlivesEnabled(true) // A reminder that this can be changed
+
+	// See: https://github.com/ipfs/go-ipfs/issues/5168
+	s.SetKeepAlivesEnabled(false)
 
 	ctx, cancel := context.WithCancel(context.Background())
 

ipfsconn/ipfshttp/ipfshttp.go

@@ -161,7 +161,9 @@ func NewConnector(cfg *Config) (*Connector, error) {
 		IdleTimeout:       cfg.ProxyIdleTimeout,
 		Handler:           smux,
 	}
-	s.SetKeepAlivesEnabled(true) // A reminder that this can be changed
+
+	// See: https://github.com/ipfs/go-ipfs/issues/5168
+	s.SetKeepAlivesEnabled(false) // A reminder that this can be changed
 
 	c := &http.Client{} // timeouts are handled by context timeouts
 

ipfsconn/ipfshttp/ipfshttp_test.go

@@ -39,6 +39,8 @@ func testIPFSConnector(t *testing.T) (*Connector, *test.IpfsMock) {
 	if err != nil {
 		t.Fatal("creating an IPFSConnector should work: ", err)
 	}
+
+	ipfs.server.SetKeepAlivesEnabled(false)
 	ipfs.SetClient(test.NewMockRPCClient(t))
 	return ipfs, mock
 }
@@ -528,8 +530,6 @@ func TestProxyAdd(t *testing.T) {
 		url := fmt.Sprintf("%s/add?"+tc.query, proxyURL(ipfs))
 		req, _ := http.NewRequest("POST", url, mr)
 		req.Header.Set("Content-Type", cType)
-		req.ContentLength = -1
-		req.Close = true
 		reqs[i] = req
 	}