review

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>

cluster_config.go

@@ -106,12 +106,12 @@ type Config struct {
 	// possible.
 	ReplicationFactorMin int
 
-	// MonitorPingInterval is the frequency by which a cluster peer pings
+	// MonitorPingInterval is the frequency with which a cluster peer pings
 	// the monitoring component. The ping metric has a TTL set to the double
 	// of this value.
 	MonitorPingInterval time.Duration
 
-	// PeerWatchInterval is the frequency that we watch for changes
+	// PeerWatchInterval is the frequency that we use to watch for changes
 	// in the consensus peerset and save new peers to the configuration
 	// file. This also affects how soon we realize that we have
 	// been removed from a cluster.

ipfscluster_test.go

@@ -208,7 +208,7 @@ func createClusters(t *testing.T) ([]*Cluster, []*test.IpfsMock) {
 	time.Sleep(200 * time.Millisecond)
 
 	// Start the rest
-	// Doing this in parallel causes libp2p dial backoffs
+	// We don't do this in parallel because it causes libp2p dial backoffs
 	for i := 1; i < nClusters; i++ {
 		clusters[i] = createCluster(t, cfgs[i], concfgs[i], apis[i], ipfss[i], states[i], trackers[i], mons[i], allocs[i], infs[i])
 		time.Sleep(200 * time.Millisecond)
@@ -1408,7 +1408,7 @@ func TestClustersRebalanceOnPeerDown(t *testing.T) {
 	}
 
 	delay()
-	waitForLeader(t, clusters) // incase we killed the leader
+	waitForLeader(t, clusters) // in case we killed the leader
 
 	// It should be now pinned in the remote pinner
 	if s := remotePinnerCluster.tracker.Status(h).Status; s != api.TrackerStatusPinned {