Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pin update options (name, expire) in ipfs-cluster-ctl #1184

Closed
hsanjuan opened this issue Jul 1, 2020 · 0 comments · Fixed by #1195
Closed

Support pin update options (name, expire) in ipfs-cluster-ctl #1184

hsanjuan opened this issue Jul 1, 2020 · 0 comments · Fixed by #1195
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Milestone
Release v0.13.1

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented Jul 1, 2020

Describe the feature you are proposing

The pin update endpoint can use name and expire options but there is no way to set them with ipfs-cluster-ctl.

#996 (comment)
@hsanjuan hsanjuan added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up good first issue Good issue for new contributors effort/hours Estimated to take one or several hours labels Jul 1, 2020
@hsanjuan hsanjuan added this to the Release v0.13.1 milestone Jul 1, 2020
omkarprabhu-98 added a commit to omkarprabhu-98/ipfs-cluster that referenced this issue Jul 21, 2020
@omkarprabhu-98
fix ipfs-cluster#1184: adds pin update options in ipfs-cluster-ctl
ac21fde
@omkarprabhu-98 omkarprabhu-98 mentioned this issue Jul 21, 2020
Merged
hsanjuan added a commit that referenced this issue Jul 21, 2020
@hsanjuan
Merge pull request #1195 from omkarprabhu-98/fix/1184-ipfs-cluster-ct…
0aa8b42 
…l-pin-update-options

Fix #1184: Pin update options (name, expire) in ipfs-cluster-ctl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
Release v0.13.1
Development

Successfully merging a pull request may close this issue.

Fix #1184: Pin update options (name, expire) in ipfs-cluster-ctl omkarprabhu-98/ipfs-cluster
1 participant
@hsanjuan