Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status information for in-flight pins does not set the name field #1212

Closed
hsanjuan opened this issue Aug 17, 2020 · 2 comments
Closed

Status information for in-flight pins does not set the name field #1212

hsanjuan opened this issue Aug 17, 2020 · 2 comments
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Milestone
Release v0.14.5

Comments

@hsanjuan
Copy link
Collaborator

The status objects include the pin names now, however this is not the case for pins that are currently being tracked (pinning, queued).

This is an issue in the pintracker module. The optracker module returns PinInfo objects that do not have the name set. This should probably be added as soon as they are tracked by checking the state (or when they are returned from the optracker).
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked exp/expert Having worked on the specific codebase is important effort/hours Estimated to take one or several hours labels Aug 17, 2020
@omkarprabhu-98
Copy link
Contributor

we can get the pin name through the operation, add it in the PinInfo returned it here? please correct me if I missed something
https://github.com/ipfs/ipfs-cluster/blob/78b3111ed688bb88a16dfcd6f955bdceb91c89c0/pintracker/optracker/operationtracker.go#L155

@hsanjuan
Copy link
Collaborator Author

Probably, not 100% sure that there are no more subtleties involved. It would need a PinName() method with a read lock like Cid().

hsanjuan added a commit that referenced this issue Jan 28, 2022
@hsanjuan
Pintracker: set Name in operation tracker. Fixes #1212.
e072b2d
@hsanjuan hsanjuan mentioned this issue Jan 28, 2022
Merged
hsanjuan added a commit that referenced this issue Jan 31, 2022
@hsanjuan
Pintracker: set Name in operation tracker. Fixes #1212.
3a19bcb
@hsanjuan hsanjuan added this to the Release v0.14.5 milestone Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/expert Having worked on the specific codebase is important kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked
Projects
None yet
Milestone
Release v0.14.5
Development

No branches or pull requests
2 participants
@hsanjuan @omkarprabhu-98