Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate secio to noise and fix docker build. #1227

Merged
merged 4 commits into from Aug 31, 2020

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 28, 2020

Closes #1214

@welcome
Copy link

welcome bot commented Aug 28, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 28, 2020

/cc @hsanjuan

@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 29, 2020

@hsanjuan this should also fix the docker build (it was calling an non existent image).

@Jorropo Jorropo changed the title Deprecate secio to noise. RMF: Deprecate secio to noise. Aug 29, 2020
@Jorropo Jorropo changed the title RMF: Deprecate secio to noise. RFM: Deprecate secio to noise. Aug 29, 2020
Copy link
Collaborator

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small ask. Thanks for contributing this!

clusterhost.go Show resolved Hide resolved
@hsanjuan hsanjuan added this to the Release v0.13.1 milestone Aug 30, 2020
@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 30, 2020

@hsanjuan done

@Jorropo Jorropo requested a review from hsanjuan August 30, 2020 12:40
@hsanjuan
Copy link
Collaborator

@Jorropo it seems docker is still borked

@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 31, 2020

@hsanjuan it works now (on my machine at least) :)

Edit:
The go test isn't working anymore, absolutely no idea why, it was working at 0393c0c but isn't at dc7a3d8 but I havn't made any change to the go code.
See the old one : https://travis-ci.com/github/ipfs/ipfs-cluster/jobs/379201483

I'm gonna try a restart.

@Jorropo Jorropo changed the title RFM: Deprecate secio to noise. RFM: Deprecate secio to noise and fix docker build. Aug 31, 2020
@Jorropo Jorropo changed the title RFM: Deprecate secio to noise and fix docker build. Deprecate secio to noise and fix docker build. Aug 31, 2020
@Jorropo
Copy link
Contributor Author

Jorropo commented Aug 31, 2020

It finally builds !

@hsanjuan hsanjuan merged commit 3ef09ee into ipfs-cluster:master Aug 31, 2020
@Jorropo Jorropo deleted the fix/1214 branch August 31, 2020 14:20
@marten-seemann marten-seemann mentioned this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate secio
2 participants