New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop using secio #1315
Comments
Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
Finally, remember to use https://discuss.ipfs.io if you just need general support. |
Instead they should use noise, and fallback to tls. This should not break compatibility with previous versions as both old and new are able to speak tls. Fixes #1315
Thanks for noticing @marten-seemann . Yeah we should have removed secio in these places too, just forgot about them. |
Instead they should use noise, and fallback to tls. This should not break compatibility with previous versions as both old and new are able to speak tls. Fixes #1315
Not really familiar with the code base here, but I see that secio is still used in https://github.com/ipfs/ipfs-cluster/blob/fab2ed814934a19b690bc402a7b499c99f661cfd/api/rest/client/transports.go#L60-L67
#1227 already removed secio from the main package.
Should we disable it here as well? And should we add Noise instead?
The text was updated successfully, but these errors were encountered: