Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using secio #1315

Closed
marten-seemann opened this issue Feb 24, 2021 · 2 comments · Fixed by #1316
Closed

stop using secio #1315

marten-seemann opened this issue Feb 24, 2021 · 2 comments · Fixed by #1316
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress

Comments

@marten-seemann
Copy link
Contributor

Not really familiar with the code base here, but I see that secio is still used in https://github.com/ipfs/ipfs-cluster/blob/fab2ed814934a19b690bc402a7b499c99f661cfd/api/rest/client/transports.go#L60-L67

#1227 already removed secio from the main package.

Should we disable it here as well? And should we add Noise instead?

@marten-seemann marten-seemann added the need/triage Needs initial labeling and prioritization label Feb 24, 2021
@welcome
Copy link

welcome bot commented Feb 24, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

hsanjuan added a commit that referenced this issue Feb 24, 2021
Instead they should use noise, and fallback to tls.

This should not break compatibility with previous versions as both old and new
are able to speak tls.

Fixes #1315
@hsanjuan hsanjuan added this to the Release v0.13.2 milestone Feb 24, 2021
@hsanjuan
Copy link
Collaborator

Thanks for noticing @marten-seemann . Yeah we should have removed secio in these places too, just forgot about them.

@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) status/in-progress In progress and removed need/triage Needs initial labeling and prioritization labels Feb 24, 2021
hsanjuan added a commit that referenced this issue Feb 24, 2021
Instead they should use noise, and fallback to tls.

This should not break compatibility with previous versions as both old and new
are able to speak tls.

Fixes #1315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) status/in-progress In progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants