Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --wait in ipfs-cluster-ctl add #1285

Closed
hsanjuan opened this issue Jan 11, 2021 · 7 comments · Fixed by #1301
Closed

Support --wait in ipfs-cluster-ctl add #1285

hsanjuan opened this issue Jan 11, 2021 · 7 comments · Fixed by #1301
Assignees
@olizilla
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Milestone
Release v0.13.2

Comments

@hsanjuan
Copy link
Collaborator

Describe the feature you are proposing

Support the --wait flag just like in pin add. This makes mostly sense when adding with --local, since that is when the process of adding might be finished and the process of pinning may take a while longer (otherwise it should be pretty quick).
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up good first issue Good issue for new contributors effort/hours Estimated to take one or several hours labels Jan 11, 2021
@hsanjuan hsanjuan mentioned this issue Jan 11, 2021
Closed
@olizilla olizilla self-assigned this Jan 21, 2021
olizilla added a commit that referenced this issue Jan 21, 2021
@olizilla
feat: add --wait flag to ipfs-cluster-ctl add
fdd685b 
A "simplest thing that could work" implementation of adding a `--wait` flag to the ipfs-cluster-ctl add command.

Allows CI to wait for cluster to fully replicate the files just added before continuting, or fail if replication fails.

Fixes #1285

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla mentioned this issue Jan 21, 2021
Merged
@RubenKelevra
Copy link
Collaborator

I think this would fix also #1067 right?

@hsanjuan
Copy link
Collaborator Author

No, not really.

@RubenKelevra
Copy link
Collaborator

Ah okay, I was getting excited too early ;D

@hsanjuan hsanjuan added this to the Release v0.13.2 milestone Jan 22, 2021
@olizilla
Copy link
Contributor

@hsanjuan when you get a moment could you cut a release of ipfs-cluster-ctl with --wait flag in from #1301

@hsanjuan
Copy link
Collaborator Author

Hey @olizilla , I'd like to release after #1319 gets addressed. The release dance is not a cheap one, but perhaps I can cut corners if you can live with an RC1.

@olizilla
Copy link
Contributor

I can live with an rc1, but don't feel you need to cut a relase early for this, just wanted to check in.

@hsanjuan
Copy link
Collaborator Author

hsanjuan commented Apr 7, 2021

@olizilla this has now shipped in 0.13.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olizilla olizilla

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
Release v0.13.2
Development

Successfully merging a pull request may close this issue.

feat: add --wait flag to ipfs-cluster-ctl add ipfs-cluster/ipfs-cluster
3 participants
@olizilla @RubenKelevra @hsanjuan