Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC calls never time out #1350

Closed
hsanjuan opened this issue May 3, 2021 · 1 comment
Closed

RPC calls never time out #1350

hsanjuan opened this issue May 3, 2021 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Milestone
Release v0.13.3

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented May 3, 2021

RPC calls (particularly Multicalls) do not have a timeout. With many peers, a single peer that is stuck can potentially block the whole operation indefinitely.
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) status/in-progress In progress P1 High: Likely tackled by core team if no one steps up labels May 3, 2021
@hsanjuan
Copy link
Collaborator Author

hsanjuan commented May 3, 2021

Indefinitely == 1 minute, the default dial timeout if it is a dial issue.

hsanjuan added a commit that referenced this issue May 3, 2021
@hsanjuan
Issue #1350: Ensure CID status and Peers do not take too long
5419d0f 
StatusCID() and Peers() are calls that should return relatively quickly.

If they don't, it means they are hanging for some reason. We cannot let the
whole Multicall request hang waiting on a single peer, therefore, set a
hardcoded 15 second deadline for both.
@hsanjuan hsanjuan added this to the Release v0.13.3 milestone May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Projects
None yet
Milestone
Release v0.13.3
Development

No branches or pull requests
1 participant
@hsanjuan