Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when unpinning via IPFS Proxy #1366

Closed
hsanjuan opened this issue Jun 21, 2021 · 0 comments
Closed

Error when unpinning via IPFS Proxy #1366

hsanjuan opened this issue Jun 21, 2021 · 0 comments
Assignees
@hsanjuan
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Milestone
Release v0.14.0

Comments

@hsanjuan
Copy link
Collaborator 

ipfs --api /ip4/127.0.0.1/tcp/9095 pin rm /ipfs/bafybeif5se5f4lwp53kthlf2kln5rmqd5thwukluqbwqqj5gpaieg2po44 -r
2021-06-21T11:46:19.436-0300    ERROR   cmds/http       error parsing error "not of type error"
Error:
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Jun 21, 2021
hsanjuan added a commit that referenced this issue Jun 28, 2021
@hsanjuan
Fix #1366: IPFS Proxy API serializes wrong error types
7e308f1 
The errors returned by the IPFS Proxy API are not understood by IPFS.

This was caused by go-ipfs-cmds setting an API error format which requires the
errors to have a type: "error" field.

This commit brings this up to speed.
@hsanjuan hsanjuan added this to the Release v0.13.4 milestone Jun 28, 2021
@hsanjuan hsanjuan self-assigned this Jun 28, 2021
hsanjuan added a commit that referenced this issue Jun 29, 2021
@hsanjuan
Merge pull request #1371 from ipfs/feat/fix-1366
55a6271 
Fix #1366: IPFS Proxy API serializes wrong error types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsanjuan hsanjuan

Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
Release v0.14.0
Development

No branches or pull requests
1 participant
@hsanjuan