Fix #1547: Store pin metadata in a sorted array #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates the Metadata protobuf map and starts serializing metadata as an array that is always sorted by the metadata key. This should resolve the issue that an state export file can be imported resulting in two different CRDT dags because the binary representation of the pin can arbitrarily change depending on how the keys in the map are listed, and thus the CID of a delta is impacted. So with this, a state export should result in exactly the same DAG regardless of where it is imported.
hsanjuan
commented
May 5, 2022
| Metadata: pin.Metadata, | ||
| PinUpdate: pin.PinUpdate.Bytes(), | ||
| ExpireAt: expireAtProto, | ||
| // Metadata: pin.Metadata, |
There was a problem hiding this comment.
Peers on older versions will not be able to see metadata for pins submitted on newer versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the Metadata protobuf map and starts serializing metadata as an
array that is always sorted by the metadata key.
This should resolve the issue that an state export file can be imported
resulting in two different CRDT dags because the binary representation of the
pin can arbitrarily change depending on how the keys in the map are listed,
and thus the CID of a delta is impacted.
So with this, a state export should result in exactly the same DAG regardless
of where it is imported.