Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PinInfo / GlobalPinInfo types should carry the peername #446

Closed
2 of 4 tasks
hsanjuan opened this issue Jun 1, 2018 · 1 comment
Closed
2 of 4 tasks

PinInfo / GlobalPinInfo types should carry the peername #446

hsanjuan opened this issue Jun 1, 2018 · 1 comment
Assignees
@kishansagathiya
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented Jun 1, 2018 •
edited

Basic information

  • Type (mark as appropiate):
    • Bug
    • Feature request
    • Enhancement

Description

We need to add a field to the PinInfo type so that the peername of the cluster peer is included in the information (just as the peer ID is). The final effect of this is that we will be able to show this output:

QmaP8aWEh8Dq6rczhxMAfZXKHZRwRGbodqTf3DZgsoZpUE :
    > Peer QmPDJG7Lw7b7QuyR5MtTTHToewfRcAWWBN6Nw58wcog8uW : REMOTE | 2018-05-31T14:11:50Z
    > Peer QmSQvhfz4wQnaDET33qQWZ8yUemLskNs2JeAAydpGLsGN9 : PINNED | 2018-05-31T14:11:50Z
    > Peer QmVxomthxuyy6ZYWHofyZd79RNuYHSHzWB2bFmkQcD3SDC : REMOTE | 2018-05-31T14:11:50Z
    > Peer QmYAajUVaFMw7EyUsZqwDhbNmCsP8L7VDRLuXNkEw6DCC1 : PINNED | 2018-05-31T14:11:50Z
    > Peer QmaHvxFk6DoNsRHqe2a7UJH66AjGDKPG2HCBxr25YYop32 : PINNED | 2018-05-31T14:11:50Z

as:

QmaP8aWEh8Dq6rczhxMAfZXKHZRwRGbodqTf3DZgsoZpUE :
    > Peer cluster0 : REMOTE | 2018-05-31T14:11:50Z
    > Peer cluster1 : PINNED | 2018-05-31T14:11:50Z
    > Peer cluster2 : REMOTE | 2018-05-31T14:11:50Z
    > Peer cluster3 : PINNED | 2018-05-31T14:11:50Z
    > Peer cluster4 : PINNED | 2018-05-31T14:11:50Z

This will require modifying the pin-trackers so that they don't only carry the peer ID, but also the peername, and to include it whenever something of PinInfo type is returned.

Once that's done, ipfs-cluster-ctl formatters need to be updated to include the peername in the output and not the peer id.
@hsanjuan hsanjuan added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up kind/enhancement A net-new feature or improvement to an existing feature labels Jun 1, 2018
@sona1111 sona1111 self-assigned this Jun 24, 2018
@kishansagathiya
Copy link
Contributor

peername is in Cluster.config. Trying to figure out how to get info from there into pinTrackers.

kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 8, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
638514f 
This commit adds peername to PinInfo and GlobalPinInfo so that we have
a nicer and more meaningfull output for queries like
`ipfs-cluster-ctl status`

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
@kishansagathiya kishansagathiya mentioned this issue Sep 8, 2018
Merged
@ghost ghost assigned kishansagathiya Sep 8, 2018
@ghost ghost added the status/in-progress In progress label Sep 8, 2018
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 12, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
dd50635 
This commit adds peername to PinInfo and GlobalPinInfo so that we have
a nicer and more meaningfull output for `ipfs-cluster-ctl` queries like
`status`, `sync` and `recover`

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 12, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
ed0fca7 
Removed comments and code used for debugging

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 12, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
0c32b4f 
Removed unnecessary peername assignment
Modified tests according to the changes made to add peername to PinInfo

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 12, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
115e42b 
Removed unnecessary peername assignment
Modified tests according to the changes made to add peername to PinInfo

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 18, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
804b419 
This commit adds peername to PinInfo and GlobalPinInfo so that we have
a nicer and more meaningfull output for queries like
`ipfs-cluster-ctl status`

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 18, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
92cdf2b 
This commit adds peername to PinInfo and GlobalPinInfo so that we have
a nicer and more meaningfull output for `ipfs-cluster-ctl` queries like
`status`, `sync` and `recover`

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 18, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
1d185d8 
Removed comments and code used for debugging

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 18, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
f549114 
Removed unnecessary peername assignment
Modified tests according to the changes made to add peername to PinInfo

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 18, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
93a8301 
Formatted output

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 24, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
ff48fb3 
This commit adds peername to PinInfo and GlobalPinInfo so that we have
a nicer and more meaningfull output for queries like
`ipfs-cluster-ctl status`

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 24, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
ef85ba8 
This commit adds peername to PinInfo and GlobalPinInfo so that we have
a nicer and more meaningfull output for `ipfs-cluster-ctl` queries like
`status`, `sync` and `recover`

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 24, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
773b4de 
Removed comments and code used for debugging

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 24, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
b76b65e 
Removed unnecessary peername assignment
Modified tests according to the changes made to add peername to PinInfo

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 24, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
61c03e2 
Formatted output

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 24, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
0580fd5 
Fixing errors and better code placement

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 24, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
2cd4420 
Fixing errors and better code placement

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya added a commit to kishansagathiya/ipfs-cluster that referenced this issue Sep 26, 2018
@kishansagathiya
Issue ipfs-cluster#446 Adding peername to PinInfo
c62c922 
Avoid typecasting

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
hsanjuan added a commit that referenced this issue Sep 26, 2018
@hsanjuan
Merge pull request #531 from kishansagathiya/issue_446
e941d6b 
Issue #446 Adding peername to PinInfo
@ghost ghost removed the status/in-progress In progress label Sep 26, 2018
@hsanjuan hsanjuan mentioned this issue Sep 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishansagathiya kishansagathiya

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hsanjuan @sona1111 @kishansagathiya