Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Daemon] Auto-trust bootstrap peers #834

Closed
hsanjuan opened this issue Jul 11, 2019 · 2 comments · Fixed by #857
Closed

[Daemon] Auto-trust bootstrap peers #834

hsanjuan opened this issue Jul 11, 2019 · 2 comments · Fixed by #857
Assignees
@kishansagathiya
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@hsanjuan
Copy link
Collaborator

Describe the feature you are proposing

Peers what we bootstrap with (--bootstrap) should be 1) trusted in consensus 2) Added to crdt trusted_peers when using crdts and saved in the config, unless a --no-trust flag is set.

Additional context

It seems the expected flow is that when you bootstrap to a peer, you implicitally trust it.
@hsanjuan hsanjuan added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P1 High: Likely tackled by core team if no one steps up labels Jul 11, 2019
@hsanjuan hsanjuan mentioned this issue Jul 11, 2019
Open
1 task
@kishansagathiya
Copy link
Contributor

saved in the config

I just want to confirm this, since we wanted to avoid cluster modifying service.json

@kishansagathiya kishansagathiya self-assigned this Jul 26, 2019
@hsanjuan
Copy link
Collaborator Author

saved in the config

I just want to confirm this, since we wanted to avoid cluster modifying service.json

I have doubts depending on the day. Do without while I think more about it.

@kishansagathiya kishansagathiya mentioned this issue Jul 27, 2019
Merged
@hsanjuan hsanjuan mentioned this issue Jul 29, 2019
Closed
hsanjuan pushed a commit that referenced this issue Jul 29, 2019
@kishansagathiya @hsanjuan
Auto-trust bootstrap peers (#857)
e0c38a2 
Fix #834: Auto-trust bootstrap peers (#857)

Add bootstrap peers to list of trusted peers for crdt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishansagathiya kishansagathiya

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Auto-trust bootstrap peers ipfs-cluster/ipfs-cluster
2 participants
@hsanjuan @kishansagathiya