Feat: add a new API component that implements the Pinning services API #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
force-pushed
the
feat/pinning-api
branch
from
a7512e3
to
5f5ffdc
Compare
|
Any hope to receive it in next release? |
|
Not in 0.14.2, but hopefully in the next one. The hardest part here is all done, it needs the tests though. |
…in peer IDs (currently will be unused)
This will facilitate building outputs for the Pinning Services API, saving a round trip to query the cluster State, since all the needed information already comes from the PinTracker, which has already accessed the state. Since the pintracker already included a state attribute (Name), we are simply going down that path.
This fixes #1213. It adds partial support for the Pinning Services API with some caveats: * RequestIDs == CIDs. This is a violation of the spec, as request IDs will not be unique etc. * Pagination, name matching, metadata matching, ordering etc. are not supported in the List endpoint. * The List endpoint only supports status filtering and cid query parameter. * Created time property is not supported and always set to Now() There is more work to do here: cleanup, extract useful types etc. and TESTS.
hsanjuan
force-pushed
the
feat/pinning-api
branch
from
36157cb
to
54a11d7
Compare
pinsvcapi: do not cache peer information here as all the needed information is in the status objects. This adds ipfs_addresses as a field broadcasted with the ping metrics.
hsanjuan
force-pushed
the
feat/pinning-api
branch
from
7b4eb45
to
5fed4a2
Compare
hsanjuan
commented
Mar 11, 2022
- Add "Created" field to pinInfo. - Support before/after filter - 404 when something is unpinned or on a non-recognize state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a new API component which is very similar to the REST API component (using the common code that was extracted from it), only to implement the Pinning Services API (or the parts that we can).
WIP #1213