Commits on Apr 11, 2022

1. Fix warnings on block-cid mismatch when adding …

   Because we are adding blocks on a single call, and we choose the format
   parameter based on the prefix of the first block, IPFS will return block CIDs
   based on that option.
   
   This caused warnings when adding content that has multiple CID prefixes: for
   example, any cid-version=1 file will include both dag-pb CIDs and raw
   CIDs. Since the first block is usually a leave, IPFS will only return
   raw-cids, and cause a warning because of the CID-mistmatch.
   
   This fixes things by comparing multihashes only.
   
   But! We might be writing blocks with the wrong CID and then the good CID won't
   work!
   
   Correct, we might, in some corner cases.
   
   In go-ipfs >= 0.12.0, all blocks are addressed by multihash so CID prefixes
   are irrelevant. This problem does not exist in that case.
   
   In go-ipfs < 0.12.0, if a read for a CIDv1 DAG-PB fails, it is retried as it
   it was raw. This means that if we wrote something with cidv1/format=raw, that
   should have been a cidv1/format=dag-pb, the read will still work. That covers
   some common cases (i.e. adding with cid-version=1) because the first block
   should be a raw-leaf. Default-params (cidv0) is not affected since everything
   is raw multihashes. However, there are still possible CAR layouts etc.  where
   cluster will write blocks wrongly to older IPFS versions.

   

   hsanjuan committed Apr 11, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for cd2fe8f
   • Browse repository at this point

   Copy the full SHA

   cd2fe8f View commit details

   Browse the repository at this point in the history