Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the error code parsing when context cancelled or deadline exceeded #2057

Merged
merged 3 commits into from
May 13, 2024
Merged

fixed the error code parsing when context cancelled or deadline exceeded #2057

merged 3 commits into from
May 13, 2024

Conversation

ohmpatel1997
Copy link
Contributor

@ohmpatel1997 ohmpatel1997 commented May 13, 2024 •
edited

hsanjuan
hsanjuan approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@hsanjuan hsanjuan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, disregard previous comment.

cmd/ipfs-cluster-ctl/main.go Outdated Show resolved Hide resolved
cmd/ipfs-cluster-ctl/main.go Outdated Show resolved Hide resolved
cmd/ipfs-cluster-ctl/main.go Outdated Show resolved Hide resolved
@hsanjuan hsanjuan added this to the Release v1.1.1 milestone May 13, 2024
@hsanjuan
Copy link
Collaborator

Many thanks for your contribution!

@hsanjuan hsanjuan merged commit f43dd61 into ipfs-cluster:master May 13, 2024
11 checks passed
@hsanjuan hsanjuan linked an issue May 13, 2024 that may be closed by this pull request
Dedicated return value on "deadline exceeded" ('--wait' timeout) #1675
Closed
@ohmpatel1997 ohmpatel1997 deleted the fix-1188/parse-duration-ctl branch May 13, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanjuan hsanjuan hsanjuan approved these changes

Assignees

@ohmpatel1997 ohmpatel1997

Labels
None yet
Projects
None yet
Milestone
Release v1.1.1
Development

Successfully merging this pull request may close these issues.

Dedicated return value on "deadline exceeded" ('--wait' timeout)
2 participants
@ohmpatel1997 @hsanjuan