Fix: validateState does not detect different state versions #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was comparing state.GetVersion() against state.Version, which is the same, instead of against, mapstate.Version, which is the constant for the current Version. It was also returning a nil error, as the scope of the variable assigned was not that of the outer level. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
ghost
assigned 
|
Changes Unknown when pulling 5b3be2d on fix/validate-state into ** on master**. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was comparing state.GetVersion() against state.Version, which
is the same, instead of against mapstate.Version, which is the
constant for the current Version.
It was also returning a nil error, as the scope of the variable
assigned was not that of the outer level.
License: MIT
Signed-off-by: Hector Sanjuan code@hector.link