Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: pintracker revamp #383

Merged
merged 14 commits into from
May 7, 2018
Merged

Feat: pintracker revamp #383

merged 14 commits into from
May 7, 2018

Commits on May 2, 2018

  1. typos and style nitpicks 

    License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame @hsanjuan
    lanzafame authored and hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    5316c3b View commit details
    Browse the repository at this point in the history

  2. ipfshttp/config: add ClientPostTimeout value 

    ipfshttp: cancel POST request when timeout reached

ipfshttp/config: fix config test

ipfshttp: use struct styling for multi-line func calls

ipfshttp/config: add general ClientTimeout

License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame @hsanjuan
    lanzafame authored and hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    a2f59b2 View commit details
    Browse the repository at this point in the history

  3. pintracker/mappintracker: separate status and operation concepts 

    The TrackerStatuses were starting to be used to convey the inflight
status of an 'operation', instead of just the status of the Pin.
I have separated out any thing related to 'operations' and
an operation's 'phases'.

License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame @hsanjuan
    lanzafame authored and hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    ab2a883 View commit details
    Browse the repository at this point in the history

  4. ipfsconn/ipfshttp: Pass ctx through from rpc_api 

    to the ipfscluster.IPFSConnector interface and then
to the implementation of that interface in ipfsconn/ipfshttp.
This allows calls from MapPinTracker to cancel requests made
to the local IPFS node.

License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame @hsanjuan
    lanzafame authored and hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    9e20e4e View commit details
    Browse the repository at this point in the history

  5. pintracker: add filtering of operationCtxs as they 

    come off the pin/unpin channels.

Also fix a race condition in the operationTracker.

License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame @hsanjuan
    lanzafame authored and hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    1eade86 View commit details
    Browse the repository at this point in the history

  6. ipfshttp: add pin/unpin specific timeouts 

    and get the tests passing and add Pin/UnpinQueued
tracker statuses back in.

License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame @hsanjuan
    lanzafame authored and hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    f68c7f5 View commit details
    Browse the repository at this point in the history

  7. pintracker: do not register operation after putting it in channel 

    This creates a race condition where the items may have been
already pinned before the operation is registered in the tracker.

This may result in operations being left in the tracker and potentially
never completed.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    5709e5d View commit details
    Browse the repository at this point in the history

  8. Pintracker: remove timeouts 

    Pinning/unpinning timeouts are controlled by the ipfs connector component.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    9856bcd View commit details
    Browse the repository at this point in the history

  9. Pintracker: rename and fmting. 

    License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    8b08dfe View commit details
    Browse the repository at this point in the history

  10. Undo extra delays 

    License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    e186dbe View commit details
    Browse the repository at this point in the history

  11. Pintracker: always cancel operation contexts 

    License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    877e65a View commit details
    Browse the repository at this point in the history

  12. Pintracker: improve tests 

    Avoid writing tests which will hang indefinitely on failure conditions.
Introduce TODOs.
Rename some vars to more explicit names.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed May 2, 2018
    Configuration menu
    Copy the full SHA
    859cf75 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2018

  1. rename operationCtx functions 

    License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame
    lanzafame committed May 4, 2018
    Configuration menu
    Copy the full SHA
    401eb40 View commit details
    Browse the repository at this point in the history

  2. finish maptracker tests 

    License: MIT
Signed-off-by: Adrian Lanzafame <adrianlanzafame92@gmail.com>
    @lanzafame
    lanzafame committed May 4, 2018
    Configuration menu
    Copy the full SHA
    19257ad View commit details
    Browse the repository at this point in the history