Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #495: Hijack proxy /add correctly. Disable keep-alives. #505

Merged
merged 5 commits into from
Aug 20, 2018
Merged

Fix #495: Hijack proxy /add correctly. Disable keep-alives. #505

merged 5 commits into from
Aug 20, 2018

Commits on Aug 18, 2018

  1. Fix #495: Hijack proxy /add correctly. 

    No more hacks around /add. This uses the local adder when hijacking /add.
It supports the parameters and works pretty well with the ipfs CLI, showing
progress and everything.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    b2914c2 View commit details
    Browse the repository at this point in the history

  2. Proxy/add: flush AddedOutput 

    License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    00a757f View commit details
    Browse the repository at this point in the history

  3. Fix: TestClustersPeerRejoin was failing a lot since DHT feature. 

    This uses Join rather than PeerAdd. Join ensures a DHT bootstrap
after successfully joining.

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    ff8476e View commit details
    Browse the repository at this point in the history

  4. Run sharness tests verbose 

    License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    0709652 View commit details
    Browse the repository at this point in the history

  5. Fix: disable KeepAlives in server 

    See discussion in ipfs/kubo#5168

We cannot stream responses with keep-alives enabled.

I prefer this to not be a client feature, as otherwise users might end up
shooting themselves in the foot.

Note, the price is a corrupted request body which gets added
normally and gives wrong hashes!

License: MIT
Signed-off-by: Hector Sanjuan <code@hector.link>
    @hsanjuan
    hsanjuan committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    be651da View commit details
    Browse the repository at this point in the history