Feat/632: support stream-channels query parameter when adding #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
This will only print the latest JSON update when adding with -Q. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
ghost
added
the
| fmt.Println(last.Cid) | ||
| } else { | ||
| formatResponse(c, *last, nil) | ||
| } |
There was a problem hiding this comment.
The code that makes use of StreamChannels bool flag is yet to be added, right?
There was a problem hiding this comment.
It's set to true by the DefaultParams() function. We won't add supports for stream-channels=false here for the moment (I think it might be enough for the requester with handling -Q better).
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
Per review comment. License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
|
@lanzafame actually when NOT passing |
|
@kishansagathiya seems the macos builder is not working well. will try another rebuild. |
|
@kishansagathiya Looks good to you? |
kishansagathiya
approved these changes
Jan 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
?stream-channels=truewill keep the current behaviour. TheAddedOutputobjects are streamed to the client as they happen.stream-channels=falsewill, however, buffer all the addedOutput objects and return them as a final json array. Stream-related headers are adjusted accordingly.The
stream-channelsis used because that's what ipfs uses (even though go-ipfs does not respect it).The proxy /add will also acquire this feature.
Additionally, this modifies
ipfs-cluster-ctl add -Qflag to apply as well when--enc=jsonis provided. This means that, in this case, only the last json-formattedAddedOutputobject will be printed (before we ignored this flag in this case and printed everything). This should facilitate parsing the root hash result when usingipfs-cluster-ctlby having valid json returned.(This PR does not add client support for
stream-channels=false. Might do that in a different PR if necessary for #632 , but I suspect it might be enough with the -Q flag change).