Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce org owners/admins #30

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Reduce org owners/admins #30

merged 2 commits into from
Feb 14, 2024

Conversation

BigLep
Copy link
Contributor

@BigLep BigLep commented Feb 12, 2024

Summary

This aligns with the "reduce org owners" step listed in ipfs/ipfs#511.

This is the first step of wider 2024Q1 permissions cleanup.

Why do you need this?

Github org safety. See ipfs/ipfs#511 for more info.

Timeline

  • 2024-02-12: public PR
  • 2024-02-12: notify affected parties:
  • 2024-02-14: merge this change assuming no major pushback

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@BigLep BigLep self-assigned this Feb 12, 2024
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipfs-examples

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # github_membership.this["aschmahmann"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipfs-examples:aschmahmann"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["autonome"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipfs-examples:autonome"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["biglep"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipfs-examples:BigLep"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

  # github_membership.this["sgtpooki"] will be updated in-place
  ~ resource "github_membership" "this" {
        id       = "ipfs-examples:SgtPooki"
      ~ role     = "admin" -> "member"
        # (2 unchanged attributes hidden)
    }

Plan: 0 to add, 4 to change, 0 to destroy.

@achingbrain
Copy link
Contributor

achingbrain commented Feb 12, 2024

Should we just retire this org and move the examples to the main IPFS org?

The js-libp2p equivalent to helia examples lives in the main libp2p org and so far it's co-existence has been drama-free.

@BigLep
Copy link
Contributor Author

BigLep commented Feb 13, 2024

Should we just retire this org and move the examples to the main IPFS org?

Good point @achingbrain . It looks like all the repos within the org are Helia or js-ipfs related.

I assume there was some initial reasons why ipfs-examples was created to begin with and that those conditions aren't holding true anymore?

I don't know who else you need to pull into the conversation and whether it's worth doing now.

Let me know how I can support.

@galargh
Copy link
Contributor

galargh commented Feb 14, 2024

I assume there was some initial reasons why ipfs-examples was created to begin with and that those conditions aren't holding true anymore?

I don't know who else you need to pull into the conversation and whether it's worth doing now.

Let me know how I can support.

I think @2color might be able to weigh in on this.

@2color
Copy link
Contributor

2color commented Feb 14, 2024

I would suggest we move these examples to the main ipfs org and do away with all the synched fork-and-go repos and just have a single monorepo.

@achingbrain wdyt?

@BigLep
Copy link
Contributor Author

BigLep commented Feb 14, 2024

I'll merge this for now since it isn't doing any harm. I'll leave it to shipyard team to decide/schedule when to do the work of deprecating the ipfs-examples org. I created a tracking item here: #31

@BigLep BigLep marked this pull request as ready for review February 14, 2024 20:53
@BigLep BigLep requested review from a team as code owners February 14, 2024 20:53
@BigLep BigLep merged commit 853924a into master Feb 14, 2024
6 checks passed
@BigLep BigLep deleted the biglep-reduce-org-owners-2024q1 branch February 14, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants