Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

fix: test each example individually #39

Merged
merged 10 commits into from
Sep 16, 2021
Merged

Conversation

achingbrain
Copy link
Contributor

@achingbrain achingbrain commented Sep 16, 2021

The current CI setup hoists all deps to the root which makes it
hard to spot when individual examples are missing dependencies.

This change switches up CI to run the tests for each example in
isolation so we should know when a dep is missing.

It also better reflects how js-ipfs tests the examples in CI.

The current CI setup hoists all deps to the root which makes it
hard to spot when individual examples are missing dependencies.

This change switches up CI to run the tests for each example in
isolation so we should know when a dep is missing.
@oliveriosousa
Copy link
Contributor

oliveriosousa commented Sep 16, 2021

Hi @achingbrain

It makes sense and I agree with you. But in my opinion we should test as a mono repo too, to check if the dependencies are being installed correctly (had problems in the past with vue for example).

Maybe we could have 2 build in parallel running as a mono repo and standalone. What do you think?

However, I don't know if it will exceed the Github Action free tier 🤔

@achingbrain
Copy link
Contributor Author

achingbrain commented Sep 16, 2021

But in my opinion we should test as a mono repo too, to check if the dependencies are being installed correctly (had problems in the past with vue for example).

I've added this back in.

I don't know if it will exceed the Github Action free tier

Me neither, I guess we'll find out 😆

@oliveriosousa oliveriosousa merged commit 9a353b8 into master Sep 16, 2021
@oliveriosousa oliveriosousa deleted the fix/test-each-example branch September 16, 2021 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants