Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/lt/multi miners config #235

Merged
merged 8 commits into from
Nov 22, 2022

Conversation

diwufeiwen
Copy link
Contributor

@diwufeiwen diwufeiwen commented Nov 11, 2022

关联的Issues (Related Issues)

close filecoin-project/venus#4952,close filecoin-project/venus#5410, close filecoin-project/venus#5021

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@diwufeiwen diwufeiwen self-assigned this Nov 11, 2022
@diwufeiwen diwufeiwen force-pushed the feat/lt/multi_miners_config branch 9 times, most recently from 4a89d3b to eaf0023 Compare November 11, 2022 09:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/v2.5.0-pre-rc1@f1f0556). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 64d77ea differs from pull request most recent head dff7894. Consider uploading reports for the commit dff7894 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                    @@
##             release/v2.5.0-pre-rc1     #235   +/-   ##
=========================================================
  Coverage                          ?   24.75%           
=========================================================
  Files                             ?      186           
  Lines                             ?    21252           
  Branches                          ?        0           
=========================================================
  Hits                              ?     5260           
  Misses                            ?    15172           
  Partials                          ?      820           
Flag Coverage Δ
unittests 24.75% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

api/clients/modules.go Outdated Show resolved Hide resolved
config/common.go Outdated Show resolved Hide resolved
rpc/auth.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/market-client/main.go Outdated Show resolved Hide resolved
minermgr/miner_mgr.go Show resolved Hide resolved
@diwufeiwen diwufeiwen force-pushed the feat/lt/multi_miners_config branch 5 times, most recently from cddf307 to 7c75899 Compare November 21, 2022 09:26
@diwufeiwen diwufeiwen merged commit 709ab8d into release/v2.5.0-pre-rc1 Nov 22, 2022
@diwufeiwen diwufeiwen deleted the feat/lt/multi_miners_config branch November 22, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants