Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support method type fee cfg / 支持消息类型级别的费用配置 #303

Merged
merged 2 commits into from Jan 6, 2023

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jan 5, 2023

关联的Issues (Related Issues)

close filecoin-project/venus#5558

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@hunjixin hunjixin self-assigned this Jan 5, 2023
@hunjixin hunjixin changed the base branch from master to dev/v1.11.0 January 5, 2023 05:28
@codecov-commenter
Copy link

Codecov Report

Merging #303 (e9421f6) into dev/v1.11.0 (0632f03) will decrease coverage by 0.64%.
The diff coverage is 54.41%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           dev/v1.11.0     #303      +/-   ##
===============================================
- Coverage        54.29%   53.65%   -0.65%     
===============================================
  Files               69       74       +5     
  Lines             7024     7712     +688     
===============================================
+ Hits              3814     4138     +324     
- Misses            2911     3262     +351     
- Partials           299      312      +13     
Flag Coverage Δ
unittests 53.65% <54.41%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/actor_cfg.go 0.00% <0.00%> (ø)
cli/address.go 0.00% <0.00%> (ø)
cli/flag.go 0.00% <ø> (ø)
cli/util.go 0.00% <0.00%> (ø)
main.go 0.00% <0.00%> (ø)
models/repo/repo.go 89.65% <ø> (ø)
service/shared_params_service.go 60.86% <ø> (ø)
models/mysql/db.go 17.54% <22.22%> (+3.98%) ⬆️
models/sqlite/db.go 67.85% <33.33%> (+4.06%) ⬆️
testhelper/mock_full_node.go 80.13% <62.50%> (-0.32%) ⬇️
... and 16 more

@hunjixin hunjixin changed the title Feat/support actor cfg Feat/support method type fee cfg / 支持消息类型级别的费用配置 Jan 5, 2023
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simlecode simlecode merged commit a32bc4a into dev/v1.11.0 Jan 6, 2023
@simlecode simlecode deleted the feat/support_actor_cfg branch January 6, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
3 participants