Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Added Group bitswap #24

Merged
merged 10 commits into from Mar 1, 2016
Merged

Added Group bitswap #24

merged 10 commits into from Mar 1, 2016

Conversation

RichardLitt
Copy link
Contributor

I added ipfs bitswap stat, wantlist, and unwant. I also added an Error object data structure for better error logging for future requests.

@RichardLitt
Copy link
Contributor Author

cc @dignifiedquire @diasdavid

```

## wantlist [GET /bitswap/wantlist{?peer}]
Show blocks currently on the wantlist.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • of a peer or itself

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the context for this comment: can you rephrase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because if the param 'peer' is passed, we will see the want list that we have from that peer, if we don't pass anything, our own want list will be shown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covered in the options. See updated code.

@daviddias
Copy link
Contributor

Looks like we are starting to get some material we can open issues on go-ipfs :)

@daviddias
Copy link
Contributor

Seems like other than the tiny tid bit here #24 (comment), this is ready to be rebased and clean merged?

@dignifiedquire
Copy link
Collaborator

needs rebase

@RichardLitt RichardLitt changed the title Added Group bitswap and its three subcommands Added Group bitswap Feb 24, 2016
@RichardLitt
Copy link
Contributor Author

Found a bug in the docs where the ability to add multiple keys isn't mentioned. Open PR. ipfs/kubo#2409

@whyrusleeping must the key in ipfs bitswap unwant <key> always be a multihash? If so, then there is a bug in here as it throws an error for empty strings.

@RichardLitt
Copy link
Contributor Author

Fixed that bug, #2409 is closed. Key is synonymous with multihash, so, yes, and b58 always returns an empty string when decoded like that. So. This is all good.

RichardLitt added a commit that referenced this pull request Mar 1, 2016
@RichardLitt RichardLitt merged commit 0dbeb2b into master Mar 1, 2016
@RichardLitt RichardLitt deleted the feature/bitswap branch March 1, 2016 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants