Move JS interface definition to a subdirectory

[magik6k]

This is in preparation for #66 / ipfs/kubo#4498.

• Why not {src,test}/{js,go}
  • Go usually has the test files in one directory together with the sources
  • Go import path would look weird: github.com/ipfs/interface-ipfs-core/src/go/.. vs github.com/ipfs/interface-ipfs-core/go/

[daviddias]

@magik6k sounds good to me. Can you also update the README?

[magik6k]

@diasdavid done (assuming that's what you meant)

[daviddias]

You only find the tests on the js/src folder. The interface definitions remain at /SPEC

[daviddias]

Can we have at least one of the go-ipfs core APIs spec'ed and tested out just to see how it feels?

[magik6k]

Can we have at least one of the go-ipfs core APIs spec'ed and tested out just to see how it feels?

For the code the plan is to just move https://github.com/ipfs/go-ipfs/tree/master/core/coreapi/interface here into go/. Written specs will probably just be docs from the interface code C-c C-v'd into /SPECS docs.

I removed the readme change as it didn't really make sense.

[ghost]

I'm not sure how well gx deals with packages in repo subdirectories. If it turns out that we have to perform in-depth surgery on gx, I'd recommend putting the Go interfaces into their own repo.

Could you try that out before we merge this PR?

[magik6k]

So I did gx init in $GOPATH/github.com/ipfs/interface-ipfs-core/go, it worked fine without any hacks, though only go/ directory was pushed to gx. This is go/package.json I got:

{
  [...]
  "bugs": {
    "url": "https://github.com/ipfs/interface-ipfs-core"
  },
  "gx": {
    "dvcsimport": "github.com/ipfs/interface-ipfs-core/go"
  },
  "gxVersion": "0.11.0",
  [...]
  "name": "go",
}

Go tooling didn't have any problems with importing this package (though if a user wants to go-get it it needs to be github.com/ipfs/interface-ipfs-core/go (note the /go)).

I'd say that it works well enough to have these things in one repo

[daviddias]

Go tooling didn't have any problems with importing this package (though if a user wants to go-get it it needs to be github.com/ipfs/interface-ipfs-core/go (note the /go)).

That's excellent! Thank you @magik6k ❤️

Mind rebasing master onto this PR to fix merge conflicts?

[magik6k]

@diasdavid done