This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
test: augment dht tests (first pass) #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
35 tasks
daviddias
changed the title
alanshaw
reviewed
Jun 4, 2018
| expect(err).to.not.exist() | ||
| withGo = id.agentVersion.startsWith('go-ipfs') | ||
| cb() | ||
| }) |
There was a problem hiding this comment.
FYI, spawnNodesWithId from above means that you already have nodeA.peerId.agentVersion
There was a problem hiding this comment.
Ah, missed that completely. Coming in a soon PR :) Thank you!
alanshaw
reviewed
Jun 4, 2018
| this.skip() | ||
| } | ||
|
|
||
| // TODO - this test needs to keep tryingl instead of the setTimeout |
There was a problem hiding this comment.
Yes please! 20s is ages to have to mandatory wait!
wraithgar
pushed a commit
that referenced
this pull request
Jun 8, 2018
* test: augment dht tests, disable the ones that are wonky for go just for go * test: skip findprovs test in go until the issue has been fixed * test: remove .only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.