This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
config API #39
Merged
config API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daviddias
commented
Jun 30, 2016
•
daviddias
commented
- js-ipfs PR make the config API spec compliant ipfs/js-ipfs#340
- js-ipfs-api PR interface-ipfs-core config API spec compliant js-ipfs-http-client#307
- needs config.replace is acting weird ipfs/kubo#2927 fixed
daviddias
force-pushed
the
config-api
branch
12 times, most recently
from
2803c66
to
0a0aa4a
Compare
|
@xicombd, @dignifiedquire, @victorbjelkholm, @nginnever, @noffle, @haadcode, @xicombd would you like to CR this PR and the two related? Namely:
Other then the hickup on go-ipfs |
| }) | ||
| }) | ||
|
|
||
| it('set a json object', (done) => { |
|
Tried testing; was unable to get the tests to run. The instructions in the Readme weren't clear on how to do this for this module only. Otherwise, LGTM. |
The tests can not be run on them own, they need to be integrated into an implementation. See js-ipfs and js-ipfs-api tests for how that looks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.