Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

add tests for refs endpoint #460

Merged
merged 9 commits into from
May 8, 2019
Merged

add tests for refs endpoint #460

merged 9 commits into from
May 8, 2019

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Apr 24, 2019

No description provided.

Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 😲 ❤️ really extensive set of tests. The only thing I'd add is a sanity test with some CBOR data to ensure it's working with other IPLD formats too.

src/files-regular/refs-local-tests.js Outdated Show resolved Hide resolved
src/files-regular/refs-local-tests.js Outdated Show resolved Hide resolved
src/files-regular/refs-tests.js Outdated Show resolved Hide resolved
src/files-regular/refs-tests.js Outdated Show resolved Hide resolved
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs command needs tests for multiple inputs.

src/files-regular/refs-tests.js Outdated Show resolved Hide resolved
src/files-regular/refs-tests.js Outdated Show resolved Hide resolved
Copy link
Contributor

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirkmc dirkmc requested a review from alanshaw May 3, 2019 15:06
@alanshaw alanshaw merged commit 326f4ca into master May 8, 2019
@ghost ghost removed the in progress label May 8, 2019
@momack2 momack2 added this to Done in ipfs/js-ipfs May 10, 2019
@momack2 momack2 added this to Done in ipfs/js-waffle May 10, 2019
@hsanjuan hsanjuan removed this from Done in ipfs/js-ipfs Apr 27, 2020
@hsanjuan hsanjuan removed this from Done in ipfs/js-waffle Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants