Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Firefox is concatenating two chunks (use case, PING) #135

Closed
daviddias opened this issue Nov 22, 2015 · 2 comments
Closed

Firefox is concatenating two chunks (use case, PING) #135

daviddias opened this issue Nov 22, 2015 · 2 comments

Comments

@daviddias
Copy link
Contributor

https://gist.github.com/Dignifiedquire/e0ce1cc876fae511ea73/raw/d5fabcca5004de459631dd814eb78634d86a720f/gistfile1.md

@whyrusleeping why does PING need to be chunked? Shouldn't it be a ndjson stream only?

It is failing on Firefox because go-ipfs is sending something that is application/json. Chrome works fine for this case though

@jbenet
Copy link
Contributor

jbenet commented Nov 30, 2015

i think a lot of these questions are based on what the golang http lib does. i think the chunked stuff happens automatically around everything else? not sure

@whyrusleeping
Copy link
Contributor

this should be fixed now. ndjson should be correctly one object per line

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants