This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
feat: support adding files via async iterator #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is super cool, note that #1063 is in the pipeline :) |
achingbrain
force-pushed
the
support-async-iterators
branch
from
933eb32
to
114fafb
Compare
3 tasks
Adds a method called `ipfs._addAsyncIterator`, prefixed with an underscore to mark it as sort of unofficial (though it's what `ipfs.add` will become once the async iterator migration is complete) and we don't want to implement symmetrical `ipfs.catAsyncIterator` etc methods, or at least not yet.
achingbrain
force-pushed
the
support-async-iterators
branch
from
114fafb
to
63faf6a
Compare
alanshaw
reviewed
Aug 28, 2019
| const stream = SendFilesStream(send, 'add')(options) | ||
|
|
||
| for await (const entry of source) { | ||
| stream.write(entry) |
There was a problem hiding this comment.
Do you need to do some conversion of entry.content?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method called
ipfs._addAsyncIterator, prefixed with an underscore to mark it as sort of unofficial (though it's whatipfs.addwill become once the async iterator migration is complete) and we don't want to implement symmetricalipfs.catAsyncIteratoretc methods, or at least not yet.Also adds support for sending the
pinand (non-standard, JS-specific)preloadarguments via HTTP.