Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

docs: browser pubsub example #1086

Merged
merged 5 commits into from
Aug 29, 2019
Merged

docs: browser pubsub example #1086

merged 5 commits into from
Aug 29, 2019

Conversation

alanshaw
Copy link
Contributor

@alanshaw alanshaw commented Aug 28, 2019 •
edited
Loading

An example demonstrating pubsub in the browser.

Screenshot 2019-07-26 at 10 11 18

TODO:

  • Add README
  • Make runnable via npm start
  • Update ipfs-http-client README to remove pubsub caveat

Depends on:

@alanshaw alanshaw mentioned this pull request Aug 28, 2019
Closed
4 tasks
@alanshaw
docs: complete documentation
e14c461 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
fix: tweaks and simplifications
1c3eb5d 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
docs: remove pubsub caveat
e257b9b 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
jacobheun
jacobheun approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the example in Brave and Firefox using js-ipfs@latest and go-ipfs master, looks good!

@alanshaw alanshaw merged commit 69a56cb into master Aug 29, 2019
@alanshaw alanshaw deleted the docs-browser-pubsub-example2 branch August 29, 2019 11:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobheun jacobheun jacobheun approved these changes

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alanshaw @jacobheun