Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Added Contribute, License, and Banner #268

Merged
merged 4 commits into from
May 11, 2016

Conversation

RichardLitt
Copy link
Contributor

Related to #152

…t Contribute, fixed a couple of grammar things

Related to #152
@@ -18,6 +18,24 @@ IPFS API wrapper library in JavaScript
$ npm install --save ipfs-api
```

#### Running the daemon with the right port

To interact with the API, you need to have a local daemon running (at the moment; we have plans to make it work independently). It needs to be open on the right port: `5001`. This is the default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local daemon running (at the moment; we have plans to make it work independently

What do you have in mind?

It needs to be open on the right port: 5001. This is the default.

The default port is 5001, but it can open any really, if the user changes the default port, then it has to change the port in the example too :)

@daviddias
Copy link
Contributor

Thank you @RichardLitt :) CR'ed

@daviddias daviddias merged commit 65f4b75 into master May 11, 2016
@daviddias daviddias deleted the feature/152-add-readme-sections branch May 11, 2016 17:43
@dignifiedquire
Copy link
Contributor

@RichardLitt why did you move the promise vs callback into the readme? It's part of the API description

@RichardLitt
Copy link
Contributor Author

Yeah, I understand that. I did it that section should apply to the entire repository, and I think it needs a higher visibility. The API.md file should be in the Readme, I think; it is more cohesive as a file on it's own without extra information like callbacks or promises. Does that make sense?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants