This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
Add metadata support #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds UnixFSv1.5 metadata support to mfs, including displaying it when listing dirs and statting files. Also adds `touch` and `chmod` commands to manipulate metadata in a similar way to the unix shell.
7 tasks
alanshaw
suggested changes
Dec 2, 2019
src/cli/cp.js
Outdated
| @@ -18,7 +18,7 @@ module.exports = { | |||
| describe: 'Create any non-existent intermediate directories' | |||
| }, | |||
| format: { | |||
| alias: 'h', | |||
| alias: 'f', | |||
There was a problem hiding this comment.
Technically a breaking change...
There was a problem hiding this comment.
Not sure - h was taken by another command so the short version of this option never worked before. More of a fix?
src/cli/mkdir.js
Outdated
| type: 'number', | ||
| default: true, | ||
| coerce: asOctal, | ||
| describe: 'Mtime to apply to the new directory' |
There was a problem hiding this comment.
As discussed, peeps probably want to use strings.
src/cli/touch.js
Outdated
| alias: 'm', | ||
| type: 'number', | ||
| default: parseInt(Date.now() / 1000), | ||
| describe: 'Time to use as the new modification time' |
There was a problem hiding this comment.
Suggested change
| describe: 'Time to use as the new modification time' | |
| describe: 'Time in seconds since the Unix epoch to use as the new modification time' |
...or is it seconds?
There was a problem hiding this comment.
It's seconds in the spec.
src/core/write.js
Outdated
|
|
||
| // persist mode & mtime if set previously | ||
| mode: (destination.unixfs && destination.unixfs.mode) || options.mode, | ||
| mtime: (destination.unixfs && destination.unixfs.mtime) ? parseInt(new Date() / 1000) : options.mtime |
There was a problem hiding this comment.
If the create flag is set and the file doesn't exist, can we set mtime and mode please?
There was a problem hiding this comment.
UnixFS entries get a default mode but not an mtime. I'll change it so it'll honour them if you pass them in.
| @@ -8,7 +8,7 @@ const multihash = require('multihashes') | |||
| const createMfs = require('./helpers/create-mfs') | |||
| const cidAtPath = require('./helpers/cid-at-path') | |||
| const createShardedDirectory = require('./helpers/create-sharded-directory') | |||
| const all = require('async-iterator-all') | |||
| const all = require('it-all') | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for UnixsFSv1.5 metadata along with
touchandchmodcommands to manipulate that metadata.Depends on: