Conversation
@@ -1,5 +1,4 @@ | |||
5 | |||
" $��G�,�A�4{���x�Z/.����D`�200Bytes.txt�3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was already not passing as of master
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was failing because git doesn't check in empty dirs. @nginnever has pushes a fix to his branch https://github.com/ipfs/js-ipfs-data-importing/pull/6/files which essentially creates the empty folders if they are not there..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noffle could you redo this PR with just the README improvs. @nginnever PR will be merged soon which adds the expected behaviour on the test. Sorry that you had to go through that trouble.
Changes made. I'm also multiplexing on the |
Blocked on #10 for now. |
greeeen #12 :) |
The |
Tests are passing! The home-made chunker used was allocating ~ |
woooo :) |
Removing chunker test file removed the node environment testing of the fixed size chunker, the test now only runs against the browser. Is this desired? The test wasn't set up to completely reduce redundancy and the same tests were in two different places and required separately instead of two requires to the same test file like in merkle-dag |
@nginnever missed that. We don't need to test the chunker anymore cause we are using block-stream2 which does it well for us. @noffle mind cleaning that part as well? Thank you both :) |
Adds a fancy-pants README, and also makes
path
anddagService
non-optional parameters.Addresses #9