Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cohosting.sh #3

Merged
merged 4 commits into from
Oct 8, 2019
Merged

feat: add cohosting.sh #3

merged 4 commits into from
Oct 8, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 5, 2019 •
edited

So here's a first iteration of cohosting.sh with the following usage:

Usage:
	./cohosting.sh add <domain>...
	./cohosting.sh rm <domain>...
	./cohosting.sh ls [domain]...
	./cohosting.sh sync
	./cohosting.sh gc [n]

<arg> for mandatory arguments. [arg] for optional ones. Not sure if that's correct.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias
feat: add cohosting.sh
8b6bff1 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested a review from lidel October 5, 2019 17:19
@hacdias
Copy link
Member Author

hacdias commented Oct 5, 2019

@lidel I think you're the best person to review this!

@hacdias hacdias mentioned this pull request Oct 6, 2019
Closed
@hacdias
Copy link
Member Author

hacdias commented Oct 6, 2019

Blocked by #4

@hacdias
fix: return instead of exiting
11fcc1b 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
lidel
lidel requested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this PoC, its really useful to have a simple script to experiment with the idea!

I think my comment at #4 (comment) should unblock you.

@hacdias
refs first
df9dfba 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
print some info
76ee1dd 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested a review from lidel October 7, 2019 16:44
@hacdias
Copy link
Member Author

hacdias commented Oct 7, 2019

@lidel it did! Just added that to the code and a few more printings to give progress info.

lidel
lidel approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's land this.

@lidel lidel merged commit 148d594 into master Oct 8, 2019
@lidel lidel deleted the feat/cohosting.sh branch October 8, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hacdias @lidel