Skip to content

Commit

Permalink
fix: Wrap long lines (or ignore warning), fix indents (Yaml lint)
Browse files Browse the repository at this point in the history
Signed-off-by: jefft0 <jeff@thefirst.org>
  • Loading branch information
jefft0 committed Sep 6, 2022
1 parent 113c9e2 commit 640c556
Show file tree
Hide file tree
Showing 6 changed files with 60 additions and 35 deletions.
23 changes: 14 additions & 9 deletions .github/ISSUE_TEMPLATE/bug_template.yml
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
# yamllint disable-line rule:document-start
name: "Bug report"
description: Report a bug found while using gomobile-ipfs.
labels: ["bug", "🔍 Ready for Review"]
assignees:
- jefft0
- jefft0
body:
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: Please search to see if an issue already exists for the bug you encountered.
description: >-
Please search to see if an issue already exists for the bug you
encountered.
options:
- label: I have searched the existing issues
required: true
- label: I have searched the existing issues
required: true
- type: input
id: package-version
attributes:
Expand All @@ -24,7 +27,8 @@ body:
attributes:
label: Language version and compiler version
description: What programming language version and compiler are you using?
placeholder: go1.17.13, javac 11.0.12, Android Studio 2021.2.1 for Android 12
placeholder: >-
go1.17.13, javac 11.0.12, Android Studio 2021.2.1 for Android 12
validations:
required: true
- type: textarea
Expand All @@ -33,16 +37,17 @@ body:
label: Bug description
description: Provide a bug description and a code snippet if applicable.
placeholder: |
1. Set up this environment ...
2. Add this code ...
3. Call this function ...
1. Set up this environment ...
2. Add this code ...
3. Call this function ...
validations:
required: true
- type: textarea
id: current-behavior
attributes:
label: Current behavior
description: Output after code execution including stack traces, debug logs, etc.
description: >-
Output after code execution including stack traces, debug logs, etc.
placeholder: Currently ...
validations:
required: true
Expand Down
20 changes: 14 additions & 6 deletions .github/ISSUE_TEMPLATE/feature_template.yml
Original file line number Diff line number Diff line change
@@ -1,33 +1,41 @@
# yamllint disable-line rule:document-start
name: "Feature request"
description: Suggest an idea for this project.
labels: [":rocket: feature-request", "🔍 Ready for Review"]
body:
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: Please search to see if an issue already exists for this feature request.
description: >-
Please search to see if an issue already exists for this feature
request.
options:
- label: I have searched the existing issues
required: true
- label: I have searched the existing issues
required: true
- type: textarea
id: feature
attributes:
label: Feature request
description: Provide a detailed description of the change or addition you are proposing.
description: >-
Provide a detailed description of the change or addition you are
proposing.
placeholder: There should be ...
validations:
required: true
- type: textarea
id: context
attributes:
label: Context
description: Why is this change important to you? How would you use it? How can it benefit other users?
description: >-
Why is this change important to you? How would you use it? How can it
benefit other users?
placeholder: This feature request is important because ...
validations:
required: true
- type: textarea
id: implementation
attributes:
label: Possible implementation
description: Not obligatory, but suggest an idea for implementing addition or change.
description: >-
Not obligatory, but suggest an idea for implementing addition or change.
placeholder: This feature could be implemented by ...
25 changes: 17 additions & 8 deletions .github/ISSUE_TEMPLATE/question_template.yml
Original file line number Diff line number Diff line change
@@ -1,34 +1,43 @@
# yamllint disable-line rule:document-start
name: "Question"
description: Ask a question about this project.
labels: ["question", "🔍 Ready for Review"]
body:
- type: checkboxes
attributes:
label: Asking a question, not reporting a bug
description: If your question is "Why did I get this error?" and you think it is a bug, then please open a Bug Report at https://github.com/ipfs-shipyard/gomobile-ipfs/issues/new/
description: >-
If your question is "Why did I get this error?" and you think it is a
bug, then please open a Bug Report at
https://github.com/ipfs-shipyard/gomobile-ipfs/issues/new/
options:
- label: This question is not about a bug
required: true
- label: This question is not about a bug
required: true
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: Please search to see if an issue already exists for your question.
description: >-
Please search to see if an issue already exists for your question.
options:
- label: I have searched the existing issues
required: true
- label: I have searched the existing issues
required: true
- type: textarea
id: question
attributes:
label: Question
description: Provide your question with enough detail that it is helpful to anyone reading the question (maybe years later).
description: >-
Provide your question with enough detail that it is helpful to anyone
reading the question (maybe years later).
placeholder: How do I ...
validations:
required: true
- type: textarea
id: context
attributes:
label: Context
description: Is it a general question about the design and goals of gomobile-ipfs, or about how to use use it in an app (or some other context)?
description: >-
Is it a general question about the design and goals of gomobile-ipfs, or
about how to use use it in an app (or some other context)?
placeholder: This is a question about ...
validations:
required: true
16 changes: 8 additions & 8 deletions .github/workflows/build-ios.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: actions/checkout@v2

- name: Set constants
run: echo "::set-output name=GOMOBILE_IPFS_VERSION::0.42.0-dev-${{ github.sha }}"
run: echo "::set-output name=GOMOBILE_IPFS_VERSION::0.42.0-dev-${{ github.sha }}" # yamllint disable-line rule:line-length
id: constants

- name: Install Go
Expand Down Expand Up @@ -59,33 +59,33 @@ jobs:
- name: Build iOS packages
working-directory: packages
env:
GOMOBILE_IPFS_VERSION: ${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}
GOMOBILE_IPFS_VERSION: ${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }} # yamllint disable-line rule:line-length
run: make build_bridge.ios

- name: Upload the core archive
uses: actions/upload-artifact@v2
with:
path: packages/build/ios/cocoapods/core/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Core-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip
name: Gomobile-IPFS-Core-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip
path: packages/build/ios/cocoapods/core/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Core-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip # yamllint disable-line rule:line-length
name: Gomobile-IPFS-Core-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip # yamllint disable-line rule:line-length
if-no-files-found: error

- name: Upload the core podspec
uses: actions/upload-artifact@v2
with:
path: packages/build/ios/cocoapods/core/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Core.podspec
path: packages/build/ios/cocoapods/core/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Core.podspec # yamllint disable-line rule:line-length
name: Gomobile-IPFS-Core.podspec
if-no-files-found: error

- name: Upload the bridge archive
uses: actions/upload-artifact@v2
with:
path: packages/build/ios/cocoapods/bridge/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Bridge-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip
name: Gomobile-IPFS-Bridge-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip
path: packages/build/ios/cocoapods/bridge/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Bridge-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip # yamllint disable-line rule:line-length
name: Gomobile-IPFS-Bridge-v${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}.pod.zip # yamllint disable-line rule:line-length
if-no-files-found: error

- name: Upload the bridge podspec
uses: actions/upload-artifact@v2
with:
path: packages/build/ios/cocoapods/bridge/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Bridge.podspec
path: packages/build/ios/cocoapods/bridge/${{ steps.constants.outputs.GOMOBILE_IPFS_VERSION }}/Gomobile-IPFS-Bridge.podspec # yamllint disable-line rule:line-length
name: Gomobile-IPFS-Bridge.podspec
if-no-files-found: error
9 changes: 6 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
# working-directory: android
# env:
# ANDROID_KEYSTORE: ${{ secrets.ANDROID_KEYSTORE }}
# run: echo "$ANDROID_KEYSTORE" | openssl base64 -A -d > gomobile-ipfs.pfx
# run: echo "$ANDROID_KEYSTORE" | openssl base64 -A -d>gomobile-ipfs.pfx

- name: Setup iOS provisioning profile
if: steps.semantic.outputs.new_release_published == 'true'
Expand Down Expand Up @@ -157,24 +157,27 @@ jobs:
if: steps.semantic.outputs.new_release_published == 'true'
working-directory: packages
env:
GOMOBILE_IPFS_VERSION: ${{ steps.semantic.outputs.new_release_version }}
GOMOBILE_IPFS_VERSION: ${{ steps.semantic.outputs.new_release_version }} # yamllint disable-line rule:line-length
run: make build_bridge.ios

- name: Add iOS artifacts to release
uses: softprops/action-gh-release@v1
with:
tag_name: v${{ steps.semantic.outputs.new_release_version }}
# yamllint disable rule:line-length
files: |
packages/build/ios/cocoapods/core/${{ steps.semantic.outputs.new_release_version }}/Gomobile-IPFS-Core-v${{ steps.semantic.outputs.new_release_version }}.pod.zip
packages/build/ios/cocoapods/core/${{ steps.semantic.outputs.new_release_version }}/Gomobile-IPFS-Core.podspec
packages/build/ios/cocoapods/bridge/${{ steps.semantic.outputs.new_release_version }}/Gomobile-IPFS-Bridge-v${{ steps.semantic.outputs.new_release_version }}.pod.zip
packages/build/ios/cocoapods/bridge/${{ steps.semantic.outputs.new_release_version }}/Gomobile-IPFS-Bridge.podspec
# yamllint enable rule:line-length

- name: Publish iOS packages
if: steps.semantic.outputs.new_release_published == 'true'
working-directory: packages
env:
# ANDROID_KEYPASS: ${{ secrets.ANDROID_KEYPASS }}
COCOAPODS_TRUNK_TOKEN: ${{ secrets.COCOAPODS_TRUNK_TOKEN }}
GOMOBILE_IPFS_VERSION: ${{ steps.semantic.outputs.new_release_version }}
GOMOBILE_IPFS_VERSION: >-
${{ steps.semantic.outputs.new_release_version }}
run: make publish.ios
2 changes: 1 addition & 1 deletion packages/Manifest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ global:
ios:
platform: :ios, '10.0'
repo: gomobile-ipfs-ios
package_url: https://github.com/{repo}/releases/download/{version}/{name}-{version}.pod.zip
package_url: https://github.com/{repo}/releases/download/{version}/{name}-{version}.pod.zip # yamllint disable-line rule:line-length

demo_app:
application_id: example
Expand Down

0 comments on commit 640c556

Please sign in to comment.