Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I do not see all the menu items #125

Closed
whoizit opened this issue Jun 24, 2016 · 8 comments
Closed

I do not see all the menu items #125

whoizit opened this issue Jun 24, 2016 · 8 comments
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Milestone

Comments

@whoizit
Copy link

whoizit commented Jun 24, 2016

2016-06-24-102053_1920x1080_scrot

I have zoom page 150% by default and it's breaks this addon.

@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Jun 25, 2016
@lidel lidel added this to the v1.6.0 milestone Jun 25, 2016
lidel added a commit that referenced this issue Jul 9, 2016
- font-size fix for #125
- fix empty menu item when API is down
- reorder items
@lidel
Copy link
Member

lidel commented Jul 9, 2016

Thank you for reporting this.

I removed font-size: small from status lines which should improve readability.
The fix will be in next release (v1.5.9)

As for missing menu items, some items are present only in specific contexts.
Which items were missing? What was the URL in address bar?

@lidel
Copy link
Member

lidel commented Aug 3, 2016

Assuming the issue is gone. Feel free to reopen if still present in v1.5.9.

@lidel lidel closed this as completed Aug 3, 2016
@whoizit
Copy link
Author

whoizit commented Jun 27, 2017

2017-06-28-014746_1920x1034_scrot
still ugly with default zoom 160%

@whoizit
Copy link
Author

whoizit commented Jun 27, 2017

2017-06-28-020716_1920x1034_scrot
2.0.0alpha6 unusable with Firefox 54

@whoizit
Copy link
Author

whoizit commented Jun 27, 2017

I feel it must be displayed as default, 100% zoom

@lidel lidel reopened this Jun 28, 2017
@lidel lidel added the UX label Jun 28, 2017
@lidel lidel modified the milestones: v2.0.0, v1.6.0 Jul 1, 2017
@lidel lidel added this to Backlog in Rewrite as WebExtension Jul 1, 2017
@lidel
Copy link
Member

lidel commented Jul 9, 2017

@atommixz are you using any additional addons that globally force zoom on all pages (both websites and browser chrome)? Or perhaps a specific GTK settings/theme?

I tried to zoom with built-in +/- menu buttons but it only zooms current tab, browser action popup remains at 100%.

Any feedback on how can I replicate this issue would be appreciated.

@lidel lidel moved this from Backlog to Research in Rewrite as WebExtension Jul 9, 2017
@whoizit
Copy link
Author

whoizit commented Jul 9, 2017

I have problem if I use 'Zoom Page' addon - https://addons.mozilla.org/firefox/addon/zoom-page/
If I disable it, I steel have problem with very popular theme for gtk 'United Gnome' - https://www.gnome-look.org/p/1174889
If I disable it, and use standard 'Clearlooks' theme, all fine.
I do not have problem with another FF addons, only this.

@lidel
Copy link
Member

lidel commented Jul 22, 2017

I was unable to replicate with 'Zoom Page' (150%) and 'United Gnome' and 2.0.0alpha7 of this addon:

2017-07-22-145023_1533x671_scrot

I suspect there is something else in play.
Perhaps you have some kind of Userstyle / Stylish customization enabled?

@lidel lidel removed this from Research in Rewrite as WebExtension Jul 22, 2017
@lidel lidel added the help wanted Seeking public contribution on this issue label Jul 22, 2017
lidel added a commit that referenced this issue Oct 8, 2017
- Do not inject browser styles, as Chrome and Firefox have
  conflicting ones
- Sizing is now based on `rem` units
- Options screen UX tweaks

Should close #125
@lidel lidel closed this as completed in 8a43015 Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants