plaintext linkification #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
implements #27 |
the8472
force-pushed
the
linkify
branch
2 times, most recently
from
0fc7bdd
to
05e3b48
Compare
| @@ -0,0 +1,15 @@ | |||
| <!doctype html> | |||
| <!-- open as resource://ipfs-firefox-addon-at-lidel-dot-org/data/test.html --> | |||
There was a problem hiding this comment.
Cool! It probably should be used in a dedicated test suite (test/test-linkify.js).
So far I did manual test and got weird results:
- Run via
jpm -b vendor/firefox-45.0a2/firefox run - I enabled at addon's
about:addonsscreen:
- Visited
resource://ipfs-firefox-addon-at-lidel-dot-org/data/test.html - Text links were not converted into
<a>tags. The only change I was able to spot was thehrefof the "abs link", which changed from
fs:/tohttps://ipfs.io/
I did not dig into the underlying code: perhaps it is still work in progress?
Or did I found a bug? :-)
yeah, missed a change when rebasing. should work now. I also added a test.
Eh, it bails out fairly early: https://github.com/lidel/ipfs-firefox-addon/pull/39/files#diff-d5184922475dad24022cebfa449bba33R166 |
lidel
added a commit
that referenced
this pull request
Jan 3, 2016
plaintext linkification + relative/native href fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting out the linkification work from the url canonization since this pretty much works while the latter is a hairy mess.