Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Adding images to ipfs sometimes adds the entire page instead #579

Closed
swedneck opened this issue Sep 16, 2018 · 1 comment
Closed

Bug: Adding images to ipfs sometimes adds the entire page instead #579

swedneck opened this issue Sep 16, 2018 · 1 comment
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/in-progress In progress

Comments

@swedneck
Copy link

For example, try right clicking the github logo and adding it to IPFS.
@lidel lidel closed this as completed Sep 18, 2018
@lidel lidel reopened this Sep 18, 2018
@lidel lidel removed the duplicate label Sep 18, 2018
@lidel
Copy link
Member

lidel commented Sep 18, 2018 •
edited
Loading

I thought this was a duplicate of #351 but I think it is a separate UX problem.

When image is also a link "Add to IPFS" picks URL of a link.
I guess user's expectation is to add image instead, so URL lookup heuristic should be changed.

@lidel lidel added UX kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue good first issue Good issue for new contributors labels Sep 18, 2018
lidel added a commit that referenced this issue Sep 18, 2018
@lidel
feat: separate context action for links
6e50669 
Closes #579
@lidel lidel mentioned this issue Sep 18, 2018
Merged
@lidel lidel added the status/in-progress In progress label Sep 22, 2018
lidel added a commit that referenced this issue Oct 1, 2018
@lidel
feat: separate context action for links
f517a3f 
Closes #579
@lidel lidel closed this as completed in #585 Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @swedneck