Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pop up new tabs on updates #933

Closed
kallisti5 opened this issue Oct 20, 2020 · 8 comments · Fixed by #935
Closed

Don't pop up new tabs on updates #933

kallisti5 opened this issue Oct 20, 2020 · 8 comments · Fixed by #935
Assignees
@lidel
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP topic/design-visual Visual design ONLY, not part of a larger UX effort

Comments

@kallisti5
Copy link

kallisti5 commented Oct 20, 2020 •
edited

Yeah... I was mid-typing something important and ipfs-companion popped up a new window for an update release notes.
Please DON'T do this anymore.

I don't mind seeing release notes in the ipfs-companion extension (maybe red circle notification or something over the icon), but spamming users with pop-ups is a sure-fire way to get a bunch of uninstalls.
@kallisti5 kallisti5 added the need/triage Needs initial labeling and prioritization label Oct 20, 2020
@welcome

This comment has been minimized.

Sign in to view
@kallisti5
Copy link
Author

At minimum... this should be "opt-in" and not "opt-out"

disabled

@lidel
Copy link
Member

lidel commented Oct 20, 2020 •
edited

Ouch, thank you for opening this issue and sorry for inconvinience 🙇‍♂️
We will definitely improve the default behaviour and remove surface for disruptions like the one you experienced.

I am mostly inspired by this prior art from 1password:

2020-10-20--17-31-36

when clicked:

2020-10-20--17-31-58

Perhaps we could do something similar:

  1. change badge color/icon to bring attention
  2. add some kind of ℹ️ icon to the header section in the popup menu?

2020-10-20--17-41-08

It would disappear after user clicks on it. We may even skip the intermediate explainer and just make it open release notes as a quick fix.

@jessicaschilling would that do?

@lidel lidel added exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP topic/design-visual Visual design ONLY, not part of a larger UX effort and removed need/triage Needs initial labeling and prioritization labels Oct 20, 2020
@lidel lidel self-assigned this Oct 20, 2020
@kallisti5
Copy link
Author

@lidel that seems like a more reasonable design :-)
Generally the add-ons that spam with pop-ups are the ones you really don't want to install lol.

@jessicaschilling
Copy link
Contributor

@kallisti5 @lidel -- this sounds good to me. I'd still leave the toggle in the prefs though, just default to off ... some users may genuinely want the active reminder 😊

@lidel, I can stub this out once my IRL emergency dies down a bit, if you don't get to it first. Will probably still need a little help with the conditional on-first-load part though -- so either I can build the UX and you can wire it up, or you could drop in the code for some really barebones UI. LMK what you'd rather.

@lidel
Copy link
Member

lidel commented Oct 20, 2020

@jessicaschilling I can wire things up. no rush, I won't have bandwidth for this any time soon, so we can tackle this next+ week.

@jessicaschilling jessicaschilling mentioned this issue Oct 21, 2020
Merged
3 tasks
@jessicaschilling
Copy link
Contributor

@lidel - #935 should be a useful start. Let me know if I can do anything else - thanks!

@kallisti5
Copy link
Author

I can confirm 2.16.0 came out and the upgrade notification is a lot more reasonable.
I actually was still "pulled into" clicking it and looking at the release notes, but it didn't interrupt my workflow.

Nice work!

@whizzzkid whizzzkid mentioned this issue Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature need/analysis Needs further analysis before proceeding P0 Critical: Tackled by core team ASAP topic/design-visual Visual design ONLY, not part of a larger UX effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: icon in browser action menu upon version update ipfs/ipfs-companion
3 participants
@kallisti5 @lidel @jessicaschilling