Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Preferences page tweaks #903

Merged
merged 4 commits into from
Jul 1, 2020
Merged

style: Preferences page tweaks #903

merged 4 commits into from
Jul 1, 2020

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Jun 25, 2020

Assorted fixes to the prefs page:

  • The big reset button is now in its own section (instead of under Experiments)
  • Updated "open in new window" icon for "read more" links to match the ones for pinning services UI added to ipfs-css: see Adds link_external icons ipfs-shipyard/ipfs-css#43
  • Tweaks language throughout prefs page for clarity

image

@jessicaschilling
Copy link
Contributor Author

@lidel, do you mind having a look when it's convenient? Thank you!

@jessicaschilling jessicaschilling changed the title Prefs page: "Reset everything" in its own section Prefs page tweaks Jun 26, 2020
@jessicaschilling
Copy link
Contributor Author

Update: @lidel This takes care of all of the items on my current crib sheet related to the prefs page, so should be good for review whenever you have the chance (no hurry). I do request that you look at the changes to text to make sure I haven't introduced any inaccuracy 😊 Thanks!

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for thorough review and fixes of all labels, really appreciate the time it took. 🙏

LGTM, I'm merging this, but will wait with release till next week, so IPFS Translation Team can apply tweaks in their locales, if needed.

@lidel lidel changed the title Prefs page tweaks style: Preferences page tweaks Jul 1, 2020
@lidel lidel merged commit 0ccb64e into master Jul 1, 2020
@lidel lidel deleted the feat/prefs-reset-newsection branch July 1, 2020 00:09
@jessicaschilling
Copy link
Contributor Author

@lidel thanks 😊 -- I've got some other Companion tweaks in the works, so we may want to wait to release anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants