Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node info bar #6

Merged
merged 2 commits into from
May 20, 2019
Merged

feat: add node info bar #6

merged 2 commits into from
May 20, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented May 15, 2019

Shows information about the node that is in focus.

Screenshot 2019-05-15 at 11 43 04

Screenshot 2019-05-15 at 11 40 44

Screenshot 2019-05-15 at 11 40 33

Screenshot 2019-05-15 at 11 40 30

screenshot

Shows information about the node that is in focus.

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw requested a review from olizilla May 15, 2019 10:48
@olizilla
Copy link
Member

O M GEEeeeEeeer

@olizilla
Copy link
Member

  1. how did you get a directory in there? Derping dirs on their aint working for me.
  2. why no links count in the UnixFS Directory stats?

@alanshaw
Copy link
Member Author

alanshaw commented May 15, 2019

1. how did you get a directory in there? Derping dirs on their aint working for me.

Right now you can drop another file on the graph after you drop the first. Needs another PR for supporting selecting/dropping multiple/directory.

2. why no links count in the UnixFS Directory stats?

Good point. It needs to get fixed. I'm using blockSizes.length but for unixfs directories these don't exist for some reason.

@alanshaw
Copy link
Member Author

@olizilla is a good PR tho?

@olizilla
Copy link
Member

very very good

@olizilla olizilla merged commit 6ad7b93 into master May 20, 2019
@olizilla olizilla deleted the feat/node-info branch May 20, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants