[WIP] Update Dependencies and make this work #511
Conversation
hacdias
commented
Nov 22, 2017
•
hacdias
commented
- Update Dependencies
- Fix Small bugs
- Fix Welcome Screen
- Move from radium to react inline styling which is exactly the same (https://reactjs.org/docs/dom-elements.html#style)
- Stateless views are now functional
|
GREEN! @diasdavid |
| "react-dom": "^15.1.0", | ||
| "react-widgets": "^3.2.0", | ||
| "react-dom": "^16.1.1", | ||
| "react-widgets": "^4.1.1", | ||
| "winston": "^2.1.0" | ||
| }, | ||
| "devDependencies": { | ||
| "babel-core": "^6.3.21", |
There was a problem hiding this comment.
While you are at it, can you add aegir as a devDep and use its aegir lint to make sure the linting rules are the same as the remaining modules?
There was a problem hiding this comment.
Should I add it to webui too?
| @@ -4,50 +4,52 @@ | |||
| "description": "IPFS Native Application", | |||
There was a problem hiding this comment.
Let's take off the 1.0.0-alpha.1, replace by 0.1.0 (that is a old pratice)
src/init.js
Outdated
| ipfs.id() | ||
| .then((peer) => { | ||
| console.log(peer) |
|
@diasdavid changed made! |
package.json
Outdated
| @@ -53,8 +56,8 @@ | |||
| }, | |||
| "scripts": { | |||
| "start": "electron src/index.js", | |||
| "test": "aegir lint", | |||
| "lint": "aegir lint", | |||
| "test": "eslint .", | |||
There was a problem hiding this comment.
We really need some tests here :)
|
@hacdias is drag and drop working? |
|
I'm not sure. It doesn't give any error but it doesn't seem to be uploading either. I'll check that when I arrive home. On train now 🚃 |
|
@diasdavid yup, it's working. It doesn't send any message telling so tho. |
|
I see we're using notifier to send notifications. Windows 10 API has changed in the last update and I think that's the reason why I'm not receiving any notification. Source: mikaelbr/node-notifier#208. Well, look at this: https://www.microsoft.com/developerblog/2016/10/30/showing-native-windows-notifications-from-electron-using-nodert/ I'll check that better and see what I can do! Edit 2: |
