feat: lazy load js-ipfs-http-client and async iterator support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lidel
force-pushed
the
feat/lazy-load-ipfs-http-client
branch
from
5eeaa4d
to
99807d9
Compare
lidel
force-pushed
the
feat/lazy-load-ipfs-http-client
branch
from
5d4f4e7
to
e4d7144
Compare
- remove external dependency - support window.IpfsHttpClient - remove defaultApiAddress (simplifies api) License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
- Renamed functions responsible for loading respective modules to more meaningful ones. - Updated examples/browser-browserify - Removed info about support for dynamic imports (JS modules) until we have a working example License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
feat/lazy-load-ipfs-http-client
branch
3 times, most recently
from
0cafb99
to
3785592
Compare
lidel
changed the title
BREAKING CHANGE: this switched ipfs-provider to the new JS APIs based on async iterators. More details in: https://blog.ipfs.io/2020-02-01-async-await-refactor/ License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel
force-pushed
the
feat/lazy-load-ipfs-http-client
branch
from
3785592
to
7901704
Compare
hacdias
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
The code LGTM! Tests seem to pass and I like the changes. Let's 1.0!
but it may impact your use cases, as you created #19 recently.
I prefer it this way where you can bring your own ipfs-http-client. Unless the constructor changes dramatically, this won't need to be updated in order for other stuff that depends on it to get updated, which is awesome.
|
@lidel Thanks for the new build. Integrated and tested on my side. Lazy load without the internal dependency is working as suggested. Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
js-ipfs-http-clientfrom the default bundle,(enabling people to lazily load it only when it is actually needed)
https://blog.ipfs.io/2020-02-01-async-await-refactor/
READMEand code in./examplesiso-url)First two are breaking changes, so I plan to release as v1.0.0.
We need this for unblocking some collabs, such as kiwix-js.