Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS Pubsub Room: version update #10

Merged
merged 1 commit into from Apr 3, 2018
Merged

Conversation

AquiGorka
Copy link
Contributor

@harrshasri
Copy link

Please Update This

@AquiGorka
Copy link
Contributor Author

AquiGorka commented Apr 3, 2018

@hacdias hello, since you are the last committer on this repo I'm pinging you to find out if this is good enough to merge.

@harrshasri
Copy link

harrshasri commented Apr 3, 2018

I think so. I was struggling to find out why ipfs is not discovering the peers when updated to 28.2
Now I got to know it is because of the interface update from dial to dialProtocol.

It could be a single word. But CRITICAL

@AquiGorka
Copy link
Contributor Author

Yep. @harrshasri you are correct. That is exactly why I submitted this PR.

@lidel
Copy link
Member

lidel commented Apr 3, 2018

cc @pgte, as I am not familiar with y-* and it seems to be used by a lot of folks :)

AFAIK lack of update blocks people from using new style of transports, people are getting Error: no protocol with name: p2p-websocket-star when trying to init with

{
  "config": {
    "Addresses": {
      "Swarm": ["/dns4/ws-star.discovery.libp2p.io/tcp/443/wss/p2p-websocket-star"]
    }
  }
}

@pgte pgte merged commit 5602180 into ipfs-shipyard:master Apr 3, 2018
@pgte
Copy link
Contributor

pgte commented Apr 3, 2018

Thanks! Landed on v2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants