Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore Protons in dep-check #1210

Open
maschad opened this issue Mar 13, 2023 · 2 comments
Open

Ignore Protons in dep-check #1210

maschad opened this issue Mar 13, 2023 · 2 comments

Comments

@maschad
Copy link
Contributor

maschad commented Mar 13, 2023 •
edited
Loading

Given we use protons to compile .proto files to .ts files across the ipfs org, we should ignore any matches including protons in our dep-check command.
@maschad maschad mentioned this issue Mar 13, 2023
Merged
@achingbrain
Copy link
Member

How do you prevent false-positives with this?

@maschad
Copy link
Contributor Author

maschad commented Mar 13, 2023

If you are referring to the scenario where protons is actually an unused dep but ignored as a result of this change, I think that's more an exception for the repos in the orgs than the norm, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achingbrain @maschad